From 15cef7e795945f7f38232f473eef14f679d29aa2 Mon Sep 17 00:00:00 2001 From: Mark Batchelder Date: Fri, 20 Nov 2015 23:14:31 -0800 Subject: [PATCH 1/2] Move aside from the widgets to the entire sidebar. It appears that the entire sidebar should be one large aside instead of making each widget it's own aside. At least that's how I understand it when reading w3. It would make sense to make each widget it's own aside if not all of the widgets were asides, but otherwise the entire sidebar should be considered one aside. Plus I think this would make more sense for accessibility and with the widgets titles being h2 because if the entire sidebar had a title that would be the h1. https://www.w3.org/wiki/HTML/Elements/aside --- functions.php | 4 ++-- sidebar.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/functions.php b/functions.php index 36ce562..a93e3dc 100644 --- a/functions.php +++ b/functions.php @@ -102,8 +102,8 @@ function _s_widgets_init() { 'name' => esc_html__( 'Sidebar', '_s' ), 'id' => 'sidebar-1', 'description' => '', - 'before_widget' => '', + 'before_widget' => '
', + 'after_widget' => '
', 'before_title' => '

', 'after_title' => '

', ) ); diff --git a/sidebar.php b/sidebar.php index b3a1f8c..1243f43 100644 --- a/sidebar.php +++ b/sidebar.php @@ -12,6 +12,6 @@ if ( ! is_active_sidebar( 'sidebar-1' ) ) { } ?> - + From 77e3087c2ec49add770d6b74be0f023103355711 Mon Sep 17 00:00:00 2001 From: Mark Batchelder Date: Tue, 24 Nov 2015 00:06:27 -0800 Subject: [PATCH 2/2] Changed widget wrapper from div to section Per https://github.com/WordPress/twentysixteen/issues/355 --- functions.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/functions.php b/functions.php index a93e3dc..d34bbd1 100644 --- a/functions.php +++ b/functions.php @@ -102,8 +102,8 @@ function _s_widgets_init() { 'name' => esc_html__( 'Sidebar', '_s' ), 'id' => 'sidebar-1', 'description' => '', - 'before_widget' => '
', - 'after_widget' => '
', + 'before_widget' => '
', + 'after_widget' => '
', 'before_title' => '

', 'after_title' => '

', ) );