Refactor navigation.js to Javascript ES6 (#1423)

This commit is contained in:
Ismail El Korchi 2020-05-15 00:26:03 +00:00 committed by GitHub
parent ef77ee91d4
commit e7d95951b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 49 additions and 62 deletions

View file

@ -1,6 +1,6 @@
{ {
"extends": [ "extends": [
"plugin:@wordpress/eslint-plugin/es5" "plugin:@wordpress/eslint-plugin/esnext"
], ],
"env": { "env": {
"browser": true "browser": true

View file

@ -5,19 +5,21 @@
* navigation support for dropdown menus. * navigation support for dropdown menus.
*/ */
( function() { ( function() {
var container, button, menu, links, i, len; const siteNavigation = document.getElementById( 'site-navigation' );
container = document.getElementById( 'site-navigation' ); // Return early if the navigation don't exist.
if ( ! container ) { if ( ! siteNavigation ) {
return; return;
} }
button = container.getElementsByTagName( 'button' )[0]; const button = siteNavigation.getElementsByTagName( 'button' )[ 0 ];
// Return early if the button don't exist.
if ( 'undefined' === typeof button ) { if ( 'undefined' === typeof button ) {
return; return;
} }
menu = container.getElementsByTagName( 'ul' )[0]; const menu = siteNavigation.getElementsByTagName( 'ul' )[ 0 ];
// Hide menu toggle button if menu is empty and return early. // Hide menu toggle button if menu is empty and return early.
if ( 'undefined' === typeof menu ) { if ( 'undefined' === typeof menu ) {
@ -26,87 +28,72 @@
} }
if ( ! menu.classList.contains( 'nav-menu' ) ) { if ( ! menu.classList.contains( 'nav-menu' ) ) {
menu.className += ' nav-menu'; menu.classList.add( 'nav-menu' );
} }
button.onclick = function() { // Toggle the .toggled class and the aria-expanded value each time the button is clicked.
if ( container.classList.contains( 'toggled' ) ) { button.addEventListener( 'click', function() {
container.className = container.className.replace( ' toggled', '' ); siteNavigation.classList.toggle( 'toggled' );
if ( button.getAttribute( 'aria-expanded' ) === 'true' ) {
button.setAttribute( 'aria-expanded', 'false' ); button.setAttribute( 'aria-expanded', 'false' );
} else { } else {
container.className += ' toggled';
button.setAttribute( 'aria-expanded', 'true' ); button.setAttribute( 'aria-expanded', 'true' );
} }
}; } );
// Close small menu when user clicks outside // Remove the .toggled class and set aria-expanded to false when the user clicks outside the navigation.
document.addEventListener( 'click', function( event ) { document.addEventListener( 'click', function( event ) {
var isClickInside = container.contains( event.target ); const isClickInside = siteNavigation.contains( event.target );
if ( ! isClickInside ) { if ( ! isClickInside ) {
container.className = container.className.replace( ' toggled', '' ); siteNavigation.classList.remove( 'toggled' );
button.setAttribute( 'aria-expanded', 'false' ); button.setAttribute( 'aria-expanded', 'false' );
} }
} ); } );
// Get all the link elements within the menu. // Get all the link elements within the menu.
links = menu.getElementsByTagName( 'a' ); const links = menu.getElementsByTagName( 'a' );
// Each time a menu link is focused or blurred, toggle focus. // Get all the link elements with children within the menu.
for ( i = 0, len = links.length; i < len; i++ ) { const linksWithChildren = menu.querySelectorAll( '.menu-item-has-children > a, .page_item_has_children > a' );
links[i].addEventListener( 'focus', toggleFocus, true );
links[i].addEventListener( 'blur', toggleFocus, true ); // Toggle focus each time a menu link is focused or blurred.
for ( const link of links ) {
link.addEventListener( 'focus', toggleFocus, true );
link.addEventListener( 'blur', toggleFocus, true );
}
// Toggle focus each time a menu link with children receive a touch event.
for ( const link of linksWithChildren ) {
link.addEventListener( 'touchstart', toggleFocus, false );
} }
/** /**
* Sets or removes .focus class on an element. * Sets or removes .focus class on an element.
*/ */
function toggleFocus() { function toggleFocus() {
var self = this; if ( event.type === 'focus' || event.type === 'blur' ) {
let self = this;
// Move up through the ancestors of the current link until we hit .nav-menu.
while ( ! self.classList.contains( 'nav-menu' ) ) {
// On li elements toggle the class .focus.
if ( 'li' === self.tagName.toLowerCase() ) {
self.classList.toggle( 'focus' );
}
self = self.parentNode;
}
}
// Move up through the ancestors of the current link until we hit .nav-menu. if ( event.type === 'touchstart' ) {
while ( ! self.classList.contains( 'nav-menu' ) ) { const menuItem = this.parentNode;
// On li elements toggle the class .focus. event.preventDefault();
if ( 'li' === self.tagName.toLowerCase() ) { for ( const link of menuItem.parentNode.children ) {
if ( self.classList.contains( 'focus' ) ) { if ( menuItem !== link ) {
self.className = self.className.replace( ' focus', '' ); link.classList.remove( 'focus' );
} else {
self.className += ' focus';
} }
} }
menuItem.classList.toggle( 'focus' );
self = self.parentElement;
} }
} }
/**
* Toggles `focus` class to allow submenu access on tablets.
*/
( function() {
var touchStartFn,
parentLink = container.querySelectorAll( '.menu-item-has-children > a, .page_item_has_children > a' );
if ( 'ontouchstart' in window ) {
touchStartFn = function( e ) {
var menuItem = this.parentNode;
if ( ! menuItem.classList.contains( 'focus' ) ) {
e.preventDefault();
for ( i = 0; i < menuItem.parentNode.children.length; ++i ) {
if ( menuItem === menuItem.parentNode.children[i] ) {
continue;
}
menuItem.parentNode.children[i].classList.remove( 'focus' );
}
menuItem.classList.add( 'focus' );
} else {
menuItem.classList.remove( 'focus' );
}
};
for ( i = 0; i < parentLink.length; ++i ) {
parentLink[i].addEventListener( 'touchstart', touchStartFn, false );
}
}
}( container ) );
}() ); }() );